sudo-rsingh/kitty
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix selections test failing due to pixel scroll

Browse Source 
Note this only fixes the test, there is still the actual issue of
the selection not being rendered for the top most line if that line is
partially scrolled offscreen
This commit is contained in:
Kovid Goyal
2026-01-08 12:40:40 +05:30
parent 1de5a9f0c6
commit b52a9031ca
2 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
kitty/screen.c
View File

@@ -5780,7 +5780,7 @@ line_edge_colors(Screen *self, PyObject *a UNUSED) {
static PyObject* static PyObject*
current_selections(Screen *self, PyObject *a UNUSED) { current_selections(Screen *self, PyObject *a UNUSED) {
PyObject *ans = PyBytes_FromStringAndSize(NULL, (Py_ssize_t)self->lines * self->columns); PyObject *ans = PyBytes_FromStringAndSize(NULL, (Py_ssize_t)render_lines_for_screen(self) * self->columns);
if (!ans) return NULL; if (!ans) return NULL;
screen_apply_selection(self, PyBytes_AS_STRING(ans), PyBytes_GET_SIZE(ans)); screen_apply_selection(self, PyBytes_AS_STRING(ans), PyBytes_GET_SIZE(ans));
return ans; return ans;

2
kitty_tests/multicell.py
View File

@@ -688,7 +688,7 @@ def test_multicell(self: TestMulticell) -> None:
pos = y * s.columns pos = y * s.columns
for x in range(x1, x2 + 1): for x in range(x1, x2 + 1):
expected[pos + x] = bp expected[pos + x] = bp
for i, (e, a) in enumerate(zip(as_lists(bytes(expected)), as_lists(actual))): for i, (e, a) in enumerate(zip(as_lists(bytes(expected)), as_lists(actual)[1:])):
self.ae(e, a, f'Row: {i}') self.ae(e, a, f'Row: {i}')
def ast(*expected, strip_trailing_whitespace=False, as_ansi=False): def ast(*expected, strip_trailing_whitespace=False, as_ansi=False):